Skip to content

Fix Doxygen warnings in IPPL API comments#499

Merged
aaadelmann merged 4 commits into
masterfrom
fix-doc
May 27, 2026
Merged

Fix Doxygen warnings in IPPL API comments#499
aaadelmann merged 4 commits into
masterfrom
fix-doc

Conversation

@aaadelmann
Copy link
Copy Markdown
Member

Clean up a first batch of API documentation issues reported by Doxygen:

  • fix over-qualified Communicator::split definition
  • remove duplicate FDTD constructor docs from implementation files
  • correct stale and mismatched @param names
  • replace malformed @Brieg command with @brief
  • avoid recursive or incorrect copydoc targets in buffer docs
  • add missing parameter names for particle, FEM, and solver APIs

Regenerating Doxygen now removes the targeted warning families and keeps the manual/API link check clean.

Clean up a first batch of API documentation issues reported by Doxygen:
- fix over-qualified Communicator::split definition
- remove duplicate FDTD constructor docs from implementation files
- correct stale and mismatched @param names
- replace malformed @Brieg command with @brief
- avoid recursive or incorrect copydoc targets in buffer docs
- add missing parameter names for particle, FEM, and solver APIs

Regenerating Doxygen now removes the targeted warning families and keeps the manual/API link check clean.
@aaadelmann aaadelmann requested a review from biddisco April 29, 2026 13:39
Copy link
Copy Markdown
Collaborator

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one typo. I don't know why the clang-format relative path fix is needed -was it broken somewhere? (I looked at the new version but couldn't quite see what it is doing, however, I trust you wouldn't put it there without checking it ...)

Comment thread AGENTS.md Outdated
Co-authored-by: John Biddiscombe <biddisco@cscs.ch>
@aaadelmann aaadelmann requested a review from biddisco May 19, 2026 15:05
@aaadelmann aaadelmann enabled auto-merge May 19, 2026 16:09
Copy link
Copy Markdown
Collaborator

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaadelmann aaadelmann added this pull request to the merge queue May 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 27, 2026
@aaadelmann aaadelmann merged commit 2bceadd into master May 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants